Skip to content

CBG-560 Remove unused DCP backfill status code #7532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 30, 2025
Merged

CBG-560 Remove unused DCP backfill status code #7532

merged 2 commits into from
May 30, 2025
+0 −318

Conversation

torcolvin
Copy link
Collaborator

@torcolvin torcolvin commented May 14, 2025 •
edited
Loading

  • This is not helpful for cbgt sharded code and this is not used by any other DCP feeds.

I identified with golang.org/x/tools/cmd/deadcode.

Pre-review checklist

  • Removed debug logging (fmt.Print, log.Print, ...)
  • Logging sensitive data? Make sure it's tagged (e.g. base.UD(docID), base.MD(dbName))
  • Updated relevant information in the API specifications (such as endpoint descriptions, schemas, ...) in docs/api

Integration Tests

@torcolvin
CBG-560 Remove unused backfill status code
c392d32 
- This is not helpful for cbgt sharded code and this is not used by
any other DCP feeds.
@torcolvin torcolvin requested a review from bbrks May 14, 2025 15:57
@torcolvin torcolvin requested review from adamcfraser and removed request for bbrks May 16, 2025 16:33
@adamcfraser adamcfraser merged commit 4840326 into main May 30, 2025
46 checks passed
@adamcfraser adamcfraser deleted the CBG-560 branch May 30, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamcfraser adamcfraser adamcfraser approved these changes

Assignees

@adamcfraser adamcfraser

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@torcolvin @adamcfraser